Skip to content

test: fix flaky debugger test #58324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: fix flaky debugger test #58324

wants to merge 1 commit into from
+1 −0

Conversation

@islandryu
Copy link
Member

@islandryu islandryu commented May 14, 2025 •
edited
Loading

For some reason, I’ve lost Jenkins permissions and can’t post the detailed URL, but I’m modifying the contents of this CI:
https://ci.nodejs.org/job/node-test-commit/79774/

I encountered this on my Windows machine when running this command.

 python3 tools/test.py --repeat=10000 parallel/test-debugger-break

node/test/parallel/test-debugger-break.js

Lines 37 to 44 in b197355

await cli.stepCommand('next');
assert.ok(
cli.output.includes(`step in ${script}:3`),
'pauses in next line of the script');
assert.match(
cli.output,
/> 3 name = 'Robin';/,
'marks the 3nd line');

The cause was the output of the cont command.
Normally, it looks like this

< Hello Robin
< 
break in test/fixtures/debugger/break.js:10
  8 }
  9 sayHello();
>10 debugger;
 11 setTimeout(sayHello, 10);
 12 
debug>

However, on rare occasions, the order of the debugger output and standard output is reversed like this:

break in test/fixtures/debugger/break.js:10
  8 }
  9 sayHello();
>10 debugger;
 11 setTimeout(sayHello, 10);
 12 
debug> 
< Hello Robin
< 
debug>

So I modified it to wait for the corresponding response before proceeding to the next command.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 14, 2025
@codecov
Copy link

codecov bot commented May 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.23%. Comparing base (4edb139) to head (bd1f167).
Report is 95 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58324      +/-   ##
==========================================
- Coverage   90.24%   90.23%   -0.01%     
==========================================
  Files         633      633              
  Lines      186860   186860              
  Branches    36675    36679       +4     
==========================================
- Hits       168623   168622       -1     
- Misses      11035    11042       +7     
+ Partials     7202     7196       -6

see 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@islandryu islandryu mentioned this pull request May 15, 2025
Merged
@ShogunPanda ShogunPanda added the request-ci Add this label to start a Jenkins CI on a PR. label May 15, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 15, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66799/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66820/

@islandryu
Copy link
Member Author

@ShogunPanda @lpinca @StefanStojanovic
The failure is just due to another flaky test, so could you please rerun the tests?

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label May 27, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 27, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67148/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67163/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@StefanStojanovic StefanStojanovic StefanStojanovic approved these changes

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@islandryu @nodejs-github-bot @lpinca @StefanStojanovic @ShogunPanda